add vertex trimming to the phase2 hlt tracking iterations #47113

lguzzi · 2025-01-16T10:25:44Z

PR description:

This PR adds vertex trimming to the phase2 hlt menu with a proc. modifier. This modifier allows to select and build only initial step seeds and high-pt triplet step doublets compatible with a subset of pixel vertices.
Preliminary studies of this configuration are available here for the legacy iterations.

PR validation:

This PR has been validated comparing the results of the customisation function used so far with the proc. modifier approach. Comparison plots show no difference.
Efficiency and fake rates for the alpaka and LST configurations are outlined here.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

not needed

cmsbuild · 2025-01-16T10:26:06Z

cms-bot internal usage

cmsbuild · 2025-01-16T10:27:10Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47113/43320

cmsbuild · 2025-01-16T10:27:36Z

A new Pull Request was created by @lguzzi for master.

It involves the following packages:

Configuration/ProcessModifiers (operations)
HLTrigger/Configuration (hlt)

@Martin-Grunewald, @antoniovilela, @cmsbuild, @davidlange6, @fabiocos, @mandrenguyen, @mmusich, @rappoccio can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @SohamBhattacharya, @VourMa, @fabiocos, @makortel, @missirol, @mmusich, @rovere this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

mmusich · 2025-01-16T10:27:59Z

Configuration/ProcessModifiers/python/vertexTrimming_cff.py

+
+# This modifier is used to enable vertex trimming in the tracking sequences
+# and in all related reconstruction modules
+vertexTrimming = cms.Modifier()


can it be renamed to signal it's about the phase-2 HLT?

I renamed it to phase2_hlt_vertexTrimming in c05a4f2

mmusich · 2025-01-16T10:28:12Z

...ration/python/HLT_75e33/modules/hltHighPtTripletStepTrackingRegionFromTrimmedVertices_cfi.py

+    scalingStartNPix        = cms.double(0.0),
+    scalingEndNPix          = cms.double(1.0),
+  ),
+  mightGet = cms.optional.untracked.vstring,


Suggested change

mightGet = cms.optional.untracked.vstring,

unneeded?

done d17f0fb

mmusich · 2025-01-16T10:28:27Z

...ration/python/HLT_75e33/modules/hltHighPtTripletStepTrackingRegionFromTrimmedVertices_cfi.py

+    useFakeVertices         = cms.bool(False),
+    maxNVertices            = cms.int32(-1),
+    nSigmaZ                 = cms.double(4.0),
+    pixelClustersForScaling = cms.InputTag('siPixelClusters'),


this is an offline product?

yes, I copied it from the defaults. It is not used in this configuration, however I changed it to hltSiPixelClusters in d17f0fb

mmusich · 2025-01-16T10:30:17Z

test parameters:

relvals_opt = --what upgrade
workflows = 29634.753, 29634.754, 29634.755, 29634.756, 29634.757, 29634.758, 29634.759, 29634.760, 29634.761
enable = hlt_p2_integration, hlt_p2_timing

mmusich · 2025-01-16T10:32:35Z

@lguzzi please add workflows that can exercise the trimming.
You can take inspiration from the other variants:

cmssw/Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py

Lines 1647 to 1685 in 547258c

    
           upgradeWFs['HLTTiming75e33Alpaka'] = deepcopy(upgradeWFs['HLTTiming75e33']) 
        
           upgradeWFs['HLTTiming75e33Alpaka'].suffix = '_HLT75e33TimingAlpaka' 
        
           upgradeWFs['HLTTiming75e33Alpaka'].offset = 0.751 
        
           upgradeWFs['HLTTiming75e33Alpaka'].step2 = { 
        
               '-s':'DIGI:pdigi_valid,L1TrackTrigger,L1,L1P2GT,DIGI2RAW,HLT:75e33_timing', 
        
               '--procModifiers': 'alpaka' 
        
           } 
        
           upgradeWFs['HLTTiming75e33TiclV5'] = deepcopy(upgradeWFs['HLTTiming75e33']) 
        
           upgradeWFs['HLTTiming75e33TiclV5'].suffix = '_HLT75e33TimingTiclV5' 
        
           upgradeWFs['HLTTiming75e33TiclV5'].offset = 0.752 
        
           upgradeWFs['HLTTiming75e33TiclV5'].step2 = { 
        
               '-s':'DIGI:pdigi_valid,L1TrackTrigger,L1,L1P2GT,DIGI2RAW,HLT:75e33_timing', 
        
               '--procModifiers': 'ticl_v5' 
        
           } 
        
           upgradeWFs['HLTTiming75e33AlpakaSingleIter'] = deepcopy(upgradeWFs['HLTTiming75e33']) 
        
           upgradeWFs['HLTTiming75e33AlpakaSingleIter'].suffix = '_HLT75e33TimingAlpakaSingleIter' 
        
           upgradeWFs['HLTTiming75e33AlpakaSingleIter'].offset = 0.753 
        
           upgradeWFs['HLTTiming75e33AlpakaSingleIter'].step2 = { 
        
               '-s':'DIGI:pdigi_valid,L1TrackTrigger,L1,L1P2GT,DIGI2RAW,HLT:75e33_timing', 
        
               '--procModifiers': 'alpaka,singleIterPatatrack' 
        
           } 
        
           upgradeWFs['HLTTiming75e33AlpakaSingleIterLST'] = deepcopy(upgradeWFs['HLTTiming75e33']) 
        
           upgradeWFs['HLTTiming75e33AlpakaSingleIterLST'].suffix = '_HLT75e33TimingAlpakaSingleIterLST' 
        
           upgradeWFs['HLTTiming75e33AlpakaSingleIterLST'].offset = 0.754 
        
           upgradeWFs['HLTTiming75e33AlpakaSingleIterLST'].step2 = { 
        
               '-s':'DIGI:pdigi_valid,L1TrackTrigger,L1,L1P2GT,DIGI2RAW,HLT:75e33_timing', 
        
               '--procModifiers': 'alpaka,singleIterPatatrack,trackingLST' 
        
           } 
        
           upgradeWFs['HLTTiming75e33AlpakaLST'] = deepcopy(upgradeWFs['HLTTiming75e33']) 
        
           upgradeWFs['HLTTiming75e33AlpakaLST'].suffix = '_HLT75e33TimingAlpakaLST' 
        
           upgradeWFs['HLTTiming75e33AlpakaLST'].offset = 0.755 
        
           upgradeWFs['HLTTiming75e33AlpakaLST'].step2 = { 
        
               '-s':'DIGI:pdigi_valid,L1TrackTrigger,L1,L1P2GT,DIGI2RAW,HLT:75e33_timing', 
        
               '--procModifiers': 'alpaka,trackingLST' 
        
           }

cmsbuild · 2025-01-16T10:43:14Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47113/43321

Found files with invalid states:
- Configuration/ProcessModifiers/python/vertexTrimming_cff.py:
  - Added: 8c2f00a
  - Deleted: c05a4f2

cmsbuild · 2025-01-16T10:43:39Z

Pull request #47113 was updated. @Martin-Grunewald, @antoniovilela, @cmsbuild, @davidlange6, @fabiocos, @mandrenguyen, @mmusich, @rappoccio can you please check and sign again.

mmusich · 2025-01-16T10:50:30Z

Configuration/ProcessModifiers/python/phase2_hlt_vertexTrimming_cff.py

+# This modifier is used to enable vertex trimming in the tracking sequences
+# and in all related reconstruction modules
+phase2_hlt_vertexTrimming = cms.Modifier()
+


this line is uneeded @lguzzi. Anyway please rebase to have just a single commit (also add the requested workflows).

cmsbuild · 2025-01-16T10:51:08Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47113/43322

Found files with invalid states:
- Configuration/ProcessModifiers/python/vertexTrimming_cff.py:
  - Added: 8c2f00a
  - Deleted: c05a4f2

cmsbuild · 2025-01-16T10:51:31Z

Pull request #47113 was updated. @Martin-Grunewald, @antoniovilela, @cmsbuild, @davidlange6, @fabiocos, @mandrenguyen, @mmusich, @rappoccio can you please check and sign again.

cmsbuild · 2025-01-28T14:39:04Z

Pull request #47113 was updated. @AdrianoDee, @Martin-Grunewald, @Moanwar, @antoniovilela, @cmsbuild, @davidlange6, @DickyChant, @fabiocos, @mandrenguyen, @miquork, @mmusich, @rappoccio, @srimanob, @subirsarkar can you please check and sign again.

lguzzi · 2025-01-28T14:39:12Z

@smuzaffar the last force push should fix the workflows.

smuzaffar · 2025-01-28T14:40:12Z

please test

cmsbuild · 2025-01-28T15:59:09Z

-1

Failed Tests: RelVals
Size: This PR adds an extra 36KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ee3df1/44001/summary.html
COMMIT: b5273ef
CMSSW: CMSSW_15_0_X_2025-01-28-1100/el8_amd64_gcc12
Additional Tests: HLT_P2_INTEGRATION,HLT_P2_TIMING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47113/44001/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

ValueError: Undefined workflows: 29634.761, 29634.758, 29634.757, 29634.759

HLT P2 Timing: chart

mmusich · 2025-01-28T16:07:51Z

Configuration/PyReleaseValidation/README.md

+* 0.758 HLT phase-2 timing menu Alpaka, trimmed tracking, single tracking iteration variant
+* 0.759 HLT phase-2 timing menu trimmed tracking, LST building variant
+* 0.760 HLT phase-2 timing menu Alpaka, trimmed tracking, LST building variant
+* 0.761 HLT phase-2 timing menu Alpaka, trimmed tracking, single tracking iteration variant, LST building variant


all of these are outdated now.

mmusich · 2025-01-28T16:09:22Z

test parameters:

relvals_opt = --what upgrade
workflows = 29634.753, 29634.754, 29634.755, 29634.756, 29634.7561, 29634.7562, 29634.7563, 29634.7564, 29634.7565
enable = hlt_p2_integration, hlt_p2_timing

cmsbuild · 2025-01-29T10:19:52Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47113/43467

There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/PyReleaseValidation/README.md modified in PR(s): [NGT] Implement NanoAOD ntuples production for HLT Muon objects #47069
- File Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py modified in PR(s): [NGT] Implement NanoAOD ntuples production for HLT Muon objects #47069, CA Extension to strips #47090, Custom Phase-2 L1 Trigger NanoAOD #47178

cmsbuild · 2025-01-29T10:20:10Z

Pull request #47113 was updated. @AdrianoDee, @Martin-Grunewald, @Moanwar, @antoniovilela, @cmsbuild, @davidlange6, @DickyChant, @fabiocos, @mandrenguyen, @miquork, @mmusich, @rappoccio, @srimanob, @subirsarkar can you please check and sign again.

mmusich · 2025-01-29T10:21:24Z

@cmsbuild, please test

cmsbuild · 2025-01-29T12:45:17Z

+1

Size: This PR adds an extra 40KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ee3df1/44018/summary.html
COMMIT: 8525b14
CMSSW: CMSSW_15_0_X_2025-01-28-2300/el8_amd64_gcc12
Additional Tests: HLT_P2_INTEGRATION,HLT_P2_TIMING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47113/44018/install.sh to create a dev area with all the needed externals and cmssw changes.

HLT P2 Timing: chart

Comparison Summary

Summary:

You potentially added 1 lines to the logs
Reco comparison results: 7 differences found in the comparisons
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 4016770
DQMHistoTests: Total failures: 60
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 4016690
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
Checked 218 log files, 189 edm output root files, 50 DQM output files
TriggerResults: no differences found

mmusich

picky, cms specific types could be dropped if they pre-exist in the modified configuration.

mmusich · 2025-01-30T09:13:49Z

HLTrigger/Configuration/python/HLT_75e33/modules/hltHighPtTripletStepHitDoublets_cfi.py

@@ -12,3 +12,6 @@
    trackingRegions = cms.InputTag("hltPhase2PixelTracksAndHighPtStepTrackingRegions"),
    trackingRegionsSeedingLayers = cms.InputTag("")
 )
+
+from Configuration.ProcessModifiers.phase2_hlt_vertexTrimming_cff import phase2_hlt_vertexTrimming
+phase2_hlt_vertexTrimming.toModify(hltHighPtTripletStepHitDoublets, trackingRegions = cms.InputTag('hltTrackingRegionFromTrimmedVertices'))


Suggested change

phase2_hlt_vertexTrimming.toModify(hltHighPtTripletStepHitDoublets, trackingRegions = cms.InputTag('hltTrackingRegionFromTrimmedVertices'))

phase2_hlt_vertexTrimming.toModify(hltHighPtTripletStepHitDoublets, trackingRegions = "hltTrackingRegionFromTrimmedVertices")

mmusich · 2025-01-30T09:14:09Z

HLTrigger/Configuration/python/HLT_75e33/modules/hltInitialStepSeeds_cfi.py

@@ -17,3 +17,6 @@

 from Configuration.ProcessModifiers.trackingLST_cff import trackingLST
 trackingLST.toModify(hltInitialStepSeeds, includeFourthHit = True)
+
+from Configuration.ProcessModifiers.phase2_hlt_vertexTrimming_cff import phase2_hlt_vertexTrimming
+phase2_hlt_vertexTrimming.toModify(hltInitialStepSeeds, InputVertexCollection = cms.InputTag("hltPhase2TrimmedPixelVertices"))


Suggested change

phase2_hlt_vertexTrimming.toModify(hltInitialStepSeeds, InputVertexCollection = cms.InputTag("hltPhase2TrimmedPixelVertices"))

phase2_hlt_vertexTrimming.toModify(hltInitialStepSeeds, InputVertexCollection = "hltPhase2TrimmedPixelVertices")

cmsbuild added this to the CMSSW_15_0_X milestone Jan 16, 2025

cmsbuild added hlt-pending operations-pending pending-signatures tests-pending orp-pending code-checks-pending labels Jan 16, 2025

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 16, 2025

mmusich reviewed Jan 16, 2025

View reviewed changes

cmsbuild added code-checks-pending and removed code-checks-approved labels Jan 16, 2025

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 16, 2025

cmsbuild added code-checks-pending and removed code-checks-approved labels Jan 16, 2025

mmusich reviewed Jan 16, 2025

View reviewed changes

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 16, 2025

lguzzi force-pushed the trimming_procModifier branch from d17f0fb to 64612ec Compare January 16, 2025 11:04

cmsbuild removed the code-checks-approved label Jan 16, 2025

cmsbuild added the code-checks-approved label Jan 28, 2025

cmsbuild added tests-started and removed tests-pending labels Jan 28, 2025

cmsbuild added tests-rejected and removed tests-started labels Jan 28, 2025

mmusich reviewed Jan 28, 2025

View reviewed changes

add trimming modules for the phase2 hlt menus

8525b14

lguzzi force-pushed the trimming_procModifier branch from b5273ef to 8525b14 Compare January 29, 2025 10:17

cmsbuild added tests-pending code-checks-pending and removed tests-rejected code-checks-approved labels Jan 29, 2025

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 29, 2025

cmsbuild added tests-started and removed tests-pending labels Jan 29, 2025

cmsbuild added operations-approved tests-approved and removed operations-pending tests-started labels Jan 29, 2025

mmusich reviewed Jan 30, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add vertex trimming to the phase2 hlt tracking iterations #47113

add vertex trimming to the phase2 hlt tracking iterations #47113

lguzzi commented Jan 16, 2025 •

edited

Loading

cmsbuild commented Jan 16, 2025 •

edited

Loading

cmsbuild commented Jan 16, 2025

cmsbuild commented Jan 16, 2025

mmusich Jan 16, 2025

lguzzi Jan 16, 2025

mmusich Jan 16, 2025

lguzzi Jan 16, 2025

mmusich Jan 16, 2025

lguzzi Jan 16, 2025

mmusich commented Jan 16, 2025 •

edited

Loading

mmusich commented Jan 16, 2025

cmsbuild commented Jan 16, 2025

cmsbuild commented Jan 16, 2025

mmusich Jan 16, 2025

cmsbuild commented Jan 16, 2025

cmsbuild commented Jan 16, 2025

cmsbuild commented Jan 28, 2025

lguzzi commented Jan 28, 2025

smuzaffar commented Jan 28, 2025

cmsbuild commented Jan 28, 2025

mmusich Jan 28, 2025

mmusich commented Jan 28, 2025

cmsbuild commented Jan 29, 2025

cmsbuild commented Jan 29, 2025

mmusich commented Jan 29, 2025

cmsbuild commented Jan 29, 2025

mmusich left a comment

mmusich Jan 30, 2025

mmusich Jan 30, 2025

	phase2_hlt_vertexTrimming.toModify(hltHighPtTripletStepHitDoublets, trackingRegions = cms.InputTag('hltTrackingRegionFromTrimmedVertices'))
	phase2_hlt_vertexTrimming.toModify(hltHighPtTripletStepHitDoublets, trackingRegions = "hltTrackingRegionFromTrimmedVertices")

	phase2_hlt_vertexTrimming.toModify(hltInitialStepSeeds, InputVertexCollection = cms.InputTag("hltPhase2TrimmedPixelVertices"))
	phase2_hlt_vertexTrimming.toModify(hltInitialStepSeeds, InputVertexCollection = "hltPhase2TrimmedPixelVertices")

add vertex trimming to the phase2 hlt tracking iterations #47113

Are you sure you want to change the base?

add vertex trimming to the phase2 hlt tracking iterations #47113

Conversation

lguzzi commented Jan 16, 2025 • edited Loading

PR description:

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

cmsbuild commented Jan 16, 2025 • edited Loading

cmsbuild commented Jan 16, 2025

cmsbuild commented Jan 16, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mmusich commented Jan 16, 2025 • edited Loading

mmusich commented Jan 16, 2025

cmsbuild commented Jan 16, 2025

cmsbuild commented Jan 16, 2025

Choose a reason for hiding this comment

cmsbuild commented Jan 16, 2025

cmsbuild commented Jan 16, 2025

cmsbuild commented Jan 28, 2025

lguzzi commented Jan 28, 2025

smuzaffar commented Jan 28, 2025

cmsbuild commented Jan 28, 2025

RelVals

Choose a reason for hiding this comment

mmusich commented Jan 28, 2025

cmsbuild commented Jan 29, 2025

cmsbuild commented Jan 29, 2025

mmusich commented Jan 29, 2025

cmsbuild commented Jan 29, 2025

Comparison Summary

mmusich left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lguzzi commented Jan 16, 2025 •

edited

Loading

cmsbuild commented Jan 16, 2025 •

edited

Loading

mmusich commented Jan 16, 2025 •

edited

Loading